-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-actions: Refactor execution container generation GH workflow; Add workflow for Ubuntu Jammy. #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uilding workflow.
…ectory base due to missing support.
…ub Actions files do not support env vars.
kirkrodrigues
requested changes
Mar 10, 2024
…ws because previous combined approach did not work.
…ild workflow file.
kirkrodrigues
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
gh-actions: Refactor execution container generation GH workflow; Add workflow for Ubuntu Jammy. (#321)
kirkrodrigues
changed the title
gh-actions: Refactor execution container generation GitHub workflow; Add the workflow for Ubuntu Jammy.
gh-actions: Refactor execution container generation GH workflow; Add workflow for Ubuntu Jammy.
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Currently, CLP execution containers, which contains the necessary dependencies to run the CLP package, is only generated for Ubuntu 20.04 (Focal).
Description
This PR refactors CLP execution images build workflow. Specifically, it:
clp-execution-image-build
) to build container images with dependencies necessary for running the CLP package. This action supports multiple Linux distributions and versions by allowing specification of the platform ID and version (e.g., Ubuntu Focal, Jammy).clp-core-build
workflow to remove trigger on changes to the new action's YAML file.clp-execution-image-build
workflow file.docs/gh-workflows.md
) to reflect the new workflows.Validation performed