-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic programming approach for schema search. #448
Draft
SharafMohamed
wants to merge
283
commits into
y-scope:main
Choose a base branch
from
SharafMohamed:dfa-search
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reviously causing a crash in log_surgeon::Buffer::read(); fixed unit test for failing to find a file
…en if it was part of a variable
… causing the heuristic to not store variable segment indicies correctly
… with schema; Ideally should use a set, but its not currently initialized
…for '.' in search query
…e search_string_view -> wildcard_expr.
…ns_for_whole_wildcard_expr; Rename possible_substr_types to interpretations.
…ome conditions into booleans for clarity.
…tended_search_string_view -> extended_wildcard_expr.
…riable-type variables to differentiate ID and name.
…ready_added_var -> already_added_dict_var.
… returns to reduce indentation and complexity; Edit some comments.
…ctionary variable to a QueryInterpretation.
…dcard expressions that match encodable-variable schemas.
…eadability of errors when unit-test fails; Move variable_type_name to more relevent location; Rename method to compare_log_types_with_expected.
…e compact; Add more complex regex test cases for wildcards
…generation in the main code is fixed.
…tions_for_whole_wildcard_expr; Add notes explaining why ?* interpretations don't have all possible variable types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Validation performed
Summary by CodeRabbit
New Features
Bug Fixes
Tests
Grep
class, including validation of wildcard expressions and interpretations.Documentation