-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily lock clang-format to v18.x to resolve lint failures. #546
Conversation
WalkthroughThe pull request modifies the version specification for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant System
User->>System: Request to update dependencies
System->>System: Check current dependencies
System->>System: Update clang-format version
System->>User: Confirm update of clang-format to version 18.x
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-authored-by: kirkrodrigues <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the PR title, how about:
Temporarily lock clang-format to v18.x to resolve lint failures (fixes #545).
…cope#546) Co-authored-by: kirkrodrigues <[email protected]>
…cope#546) Co-authored-by: kirkrodrigues <[email protected]>
Description
The lint workflow, as reported in #545
This PR locks the clang-format version to 18.1.8 (which is the latest version 18 release in PyPI) as a temporary solution. We will fix this properly later by adapting clang-format version 19.
Validation performed
Ensure the lint workflow passed: https://github.com/LinZhihao-723/clp/actions/runs/11018322868
Summary by CodeRabbit
clang-format
dependency to ensure compatibility and maintain formatting standards.