Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clp-package): Add support for deleting archives that are exclusively within a time range. #594
feat(clp-package): Add support for deleting archives that are exclusively within a time range. #594
Changes from 10 commits
dc9366b
2800244
def142e
d1e1f01
67182ba
9e8fa85
2e76916
478d8ca
b081710
a16e8bc
816892a
4e73e4d
0a31847
9449c52
1127973
59e0cae
fe76015
e3306da
1548ae3
73b656b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a brand new script, let's use our latest conventions and best practices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve timestamp handling in SQL query
The current implementation has an unresolved issue with large integer timestamps. Consider alternative approaches for handling large integers.
Here are potential solutions:
Please test these solutions to determine which one resolves the integer overflow issue in your environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, managed to resolve it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haiqi96, great to hear that you resolved the issue!
If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!