Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clp-package): Remove faulty error handling for parsing archive compression stats. #640

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(clp-package): Remove faulty error handling for parsing archive compression stats. #640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions components/job-orchestration/job_orchestration/executor/compress/fs_compression_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,16 +243,13 @@ def run_clp(
# Handle job metadata update and s3 write if enabled
s3_error = None
while not last_line_decoded:
line = proc.stdout.readline()
stats: Optional[Dict[str, Any]] = None
if "" == line:
# Skip empty lines that could be caused by potential errors in printing archive stats
continue

if line is not None:
stats = json.loads(line.decode("ascii"))
else:
line = proc.stdout.readline()
if not line:
last_line_decoded = True
else:
stats = json.loads(line.decode("ascii"))

if last_archive_stats is not None and (
None is stats or stats["id"] != last_archive_stats["id"]
Expand Down
Loading