Skip to content

Commit

Permalink
new-log-viewer: Treat ESLint warnings as errors; Remove `ataylorme/es…
Browse files Browse the repository at this point in the history
…lint-annotate-action` and instead rely on `setup-node`'s problem matcher to annotate ESLint errors in PRs. (#71)
  • Loading branch information
junhaoliao authored Sep 16, 2024
1 parent 2f653eb commit 0ba5cff
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 15 deletions.
14 changes: 1 addition & 13 deletions .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ concurrency:
jobs:
lint-check:
runs-on: "ubuntu-latest"
permissions:
# So `eslint-annotate-action` can create / update status checks
checks: "write"
# So `eslint-annotate-action` can get pull request files
contents: "read"
steps:
- uses: "actions/checkout@v4"
with:
Expand All @@ -34,11 +29,4 @@ jobs:
with:
node-version: 22
- run: "npm --prefix new-log-viewer/ clean-install"
- run: "npm --prefix new-log-viewer/ run lint:ci"
continue-on-error: true
- uses: "ataylorme/eslint-annotate-action@v3"
with:
fail-on-error: true
fail-on-warning: true
only-pr-files: true
report-json: "./new-log-viewer/eslint-report.json"
- run: "npm --prefix new-log-viewer/ run lint:check"
3 changes: 1 addition & 2 deletions new-log-viewer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
"scripts": {
"build": "webpack --config webpack.prod.js",
"lint": "npm run lint:check",
"lint:ci": "npm run lint:check -- --output-file eslint-report.json --format json",
"lint:check": "eslint src webpack.*.js",
"lint:check": "eslint src webpack.*.js --max-warnings 0",
"lint:fix": "npm run lint:check -- --fix",
"start": "webpack serve --open --config webpack.dev.js"
},
Expand Down

0 comments on commit 0ba5cff

Please sign in to comment.