junhao review

y-scope · Nov 28, 2024 · 98bad59 · 98bad59
1 parent 53491e7
commit 98bad59
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/components/CentralContainer/Sidebar/SidebarTabs/index.tsx b/src/components/CentralContainer/Sidebar/SidebarTabs/index.tsx
@@ -16,6 +16,7 @@ import SettingsOutlinedIcon from "@mui/icons-material/SettingsOutlined";
 
 import {StateContext} from "../../../../contexts/StateContextProvider";
 import {TAB_NAME} from "../../../../typings/tab";
+import {openInNewTab} from "../../../../utils/url";
 import SettingsModal from "../../../modals/SettingsModal";
 import FileInfoTabPanel from "./FileInfoTabPanel";
 import SearchTabPanel from "./SearchTabPanel";
@@ -67,7 +68,7 @@ const SidebarTabs = forwardRef<HTMLDivElement, SidebarTabsProps>((
                 setIsSettingsModalOpen(true);
                 break;
             case TAB_NAME.DOCUMENTATION:
-                window.open(DOCUMENTATION_URL, "_blank", "noopener");
+                openInNewTab(DOCUMENTATION_URL);
                 break;
             default:
                 onActiveTabNameChange(tabName);

diff --git a/src/utils/url.ts b/src/utils/url.ts
@@ -44,8 +44,17 @@ const getBasenameFromUrlOrDefault = (
     return basename;
 };
 
+/**
+ * Opens a given URL in a new browser tab.
+ *
+ * @param url
+ */
+const openInNewTab = (url: string): void => {
+    window.open(url, "_blank", "noopener");
+};
 
 export {
     getAbsoluteUrl,
     getBasenameFromUrlOrDefault,
+    openInNewTab,
 };