Apply suggestions from code review

Co-authored-by: Junhao Liao <[email protected]>
y-scope · Sep 16, 2024 · b9ab9dd · b9ab9dd
1 parent b127bbf
commit b9ab9dd
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 7 deletions.
diff --git a/new-log-viewer/src/contexts/StateContextProvider.tsx b/new-log-viewer/src/contexts/StateContextProvider.tsx
@@ -161,7 +161,6 @@ const StateContextProvider = ({children}: StateContextProviderProps) => {
         switch (code) {
             case WORKER_RESP_CODE.CHUNK_DATA:
                 receivedNumChunksRef.current += 1;
-                console.log(receivedNumChunksRef.current, args.logs);
 
                 // If all chunks are received, trigger the download of the file
                 if (numChunks === receivedNumChunksRef.current) {

diff --git a/new-log-viewer/src/services/LogFileManager.ts b/new-log-viewer/src/services/LogFileManager.ts
@@ -166,11 +166,7 @@ class LogFileManager {
                 `eventIdx=${eventIdx});`);
         }
 
-        const messages: string[] = [];
-        results.forEach((r) => {
-            const [msg] = r;
-            messages.push(msg);
-        });
+        const messages = results.map(([msg]) => msg);
 
         return {
             logs: messages.join(""),

diff --git a/new-log-viewer/src/services/MainWorker.ts b/new-log-viewer/src/services/MainWorker.ts
@@ -18,7 +18,6 @@ dayjs.extend(dayjsUtc);
 dayjs.extend(dayjsTimezone);
 /* eslint-enable import/no-named-as-default-member */
 
-
 /**
  * Manager for the currently opened log file.
  */
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,7 +18,6 @@ dayjs.extend(dayjsUtc); @@
     dayjs.extend(dayjsTimezone);
     /* eslint-enable import/no-named-as-default-member */
     /**
      * Manager for the currently opened log file.
      */
@@ Expand Down @@