Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint): Replace deprecated Stylelint Github formatter with a Github problem matcher. #112

Merged
merged 9 commits into from
Nov 25, 2024
Merged

ci(lint): Replace deprecated Stylelint Github formatter with a Github problem matcher. #112

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
54c1413
gh-workflow: Add Stylelint problem matcher to GitHub Actions, replaci…
junhaoliao Nov 4, 2024
598af7a
Add missing newlines to EOFs.
junhaoliao Nov 4, 2024
155b067
Remove script `lint:ci` and use `lint:check` in GH workflow - Apply s…
junhaoliao Nov 21, 2024
adc0e9e
Add `owner` when removing the matcher - Apply suggestions from code r…
junhaoliao Nov 21, 2024
77b8f39
Extract a constant for the stylelint problem matcher path.
junhaoliao Nov 21, 2024
1edf8fc
Update step name `lint:ci` -> `lint:check`.
junhaoliao Nov 21, 2024
6e6d5d8
Merge branch 'main' into stylelint-remove-formatter
junhaoliao Nov 21, 2024
c684c88
Add back `owner` into `remove-matcher`.
junhaoliao Nov 21, 2024
32d5ba5
Correct `remove-matcher` syntax.
junhaoliao Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/problem-matchers/stylelint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"problemMatcher": [
{
"owner": "stylelint",
"pattern": [
{
"regexp": "^([^\\s].*)$",
"file": 1
},
{
"regexp": "^\\s*(\\d+):(\\d+)\\s+(\\S+)\\s+(.+?)\\s+(\\S+)$",
"line": 1,
"column": 2,
"message": 4,
"code": 5,
"loop": true
}
]
}
]
}
junhaoliao marked this conversation as resolved.
Show resolved Hide resolved
11 changes: 10 additions & 1 deletion .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,13 @@ jobs:
with:
node-version: 22
- run: "npm clean-install"
- run: "npm run lint:ci"
- name: "Set up Stylelint Problem Matcher"
run: "echo '::add-matcher::./.github/problem-matchers/stylelint.json'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a variable for the file path? and reuse it later?

- name: "Run `lint:ci` script."
run: |-
# Disable ANSI color codes in Stylelint default "string" formatter
export NO_COLOR=1
npm run lint:ci
junhaoliao marked this conversation as resolved.
Show resolved Hide resolved
- if: "always()"
name: "Remove Stylelint Problem Matcher"
run: "echo '::remove-matcher::./.github/problem-matchers/stylelint.json'"
junhaoliao marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"lint:check": "npm-run-all --sequential --continue-on-error lint:check:*",
"lint:check:css": "stylelint src/**/*.css",
"lint:check:js": "eslint src webpack.*.js --max-warnings 0",
"lint:ci": "npm-run-all --sequential --continue-on-error lint:check:js \"lint:check:css -- --formatter github\"",
"lint:ci": "npm-run-all --sequential --continue-on-error lint:check:*",
junhaoliao marked this conversation as resolved.
Show resolved Hide resolved
"lint:fix": "npm-run-all --parallel --continue-on-error \"lint:check:* -- --fix\""
},
"repository": {
Expand Down