-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(lint): Replace deprecated Stylelint Github formatter with a Github problem matcher. #112
Merged
junhaoliao
merged 9 commits into
y-scope:main
from
junhaoliao:stylelint-remove-formatter
Nov 25, 2024
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
54c1413
gh-workflow: Add Stylelint problem matcher to GitHub Actions, replaci…
junhaoliao 598af7a
Add missing newlines to EOFs.
junhaoliao 155b067
Remove script `lint:ci` and use `lint:check` in GH workflow - Apply s…
junhaoliao adc0e9e
Add `owner` when removing the matcher - Apply suggestions from code r…
junhaoliao 77b8f39
Extract a constant for the stylelint problem matcher path.
junhaoliao 1edf8fc
Update step name `lint:ci` -> `lint:check`.
junhaoliao 6e6d5d8
Merge branch 'main' into stylelint-remove-formatter
junhaoliao c684c88
Add back `owner` into `remove-matcher`.
junhaoliao 32d5ba5
Correct `remove-matcher` syntax.
junhaoliao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
{ | ||
"problemMatcher": [ | ||
{ | ||
"owner": "stylelint", | ||
"pattern": [ | ||
{ | ||
"regexp": "^([^\\s].*)$", | ||
"file": 1 | ||
}, | ||
{ | ||
"regexp": "^\\s*(\\d+):(\\d+)\\s+(\\S+)\\s+(.+?)\\s+(\\S+)$", | ||
"line": 1, | ||
"column": 2, | ||
"message": 4, | ||
"code": 5, | ||
"loop": true | ||
} | ||
] | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a variable for the file path? and reuse it later?