Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): Fix sidebar tab list overflow on auto-collapse (fixes #124). #145

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

junhaoliao
Copy link
Collaborator

@junhaoliao junhaoliao commented Dec 1, 2024

Description

fixes #124

  1. Change the CSS property overflow-y to overflow in class .sidebar-tabs so that the behaviour is explicitly specified both the x & y directions.

Validation performed

  1. Repeated the "Reproduction steps" in the issue.
  2. Observed the scroll indicator did not show up when auto-collapse was triggered.

Summary by CodeRabbit

  • Style
    • Updated the overflow behavior of the sidebar tabs to enhance the user interface.

Copy link

coderabbitai bot commented Dec 1, 2024

Walkthrough

The pull request modifies the CSS for the .sidebar-tabs class in the index.css file. The change involves updating the overflow property from overflow-y: hidden; to overflow: hidden;, affecting both horizontal and vertical overflow behavior. Other CSS properties such as flex-grow, width, and height remain unchanged.

Changes

File Change Summary
src/components/CentralContainer/Sidebar/SidebarTabs/index.css Updated .sidebar-tabs overflow property from overflow-y: hidden; to overflow: hidden;

Possibly related PRs

Suggested reviewers

  • Henry8192
  • davemarco

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 969ff35 and 843554b.

📒 Files selected for processing (1)
  • src/components/CentralContainer/Sidebar/SidebarTabs/index.css (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/components/CentralContainer/Sidebar/SidebarTabs/index.css

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@junhaoliao junhaoliao changed the title fix(sidebar): Fix sidebar tab list overflow on auto-collapse (fixes #144). fix(sidebar): Fix sidebar tab list overflow on auto-collapse (fixes #124). Dec 2, 2024
@junhaoliao junhaoliao requested a review from Henry8192 December 2, 2024 00:40
Copy link
Collaborator

@Henry8192 Henry8192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@junhaoliao junhaoliao merged commit 2f69e27 into y-scope:main Dec 3, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manually closing sidebar tab panel is shrinking tabs causing overflow in UI.
2 participants