Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(URL): Add support to query timestamp by URL #152
base: main
Are you sure you want to change the base?
feat(URL): Add support to query timestamp by URL #152
Changes from all commits
5477d0a
4a8aeb7
7f5cc7f
54ef03c
6c2b45a
255f3e3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 457 in src/contexts/StateContextProvider.tsx
GitHub Actions / lint-check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be more concise and avoid the nested function declaration? (haven't tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this?
Check failure on line 81 in src/services/decoders/ClpIrDecoder.ts
GitHub Actions / lint-check
Check failure on line 81 in src/services/decoders/ClpIrDecoder.ts
GitHub Actions / lint-check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's see if the suggestion at https://github.com/y-scope/yscope-log-viewer/pull/152/files#r1890816021 makes sense. If not (i.e., we want to keep the return type as
number
rather thanNullable<number>
), let's create a const for-1
so we can avoid magic numbers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
@ts-expect-error
disables type-checking for the whole following line, can we extract aconst midLogEvent = this.#logEvents[mid];
and only disable type-checking for that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we return
null
no such event is found?