Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Replace React-Boostrap elements with vscode-webview-ui-toolkit ones. #42

Closed
wants to merge 3 commits into from

Conversation

junhaoliao
Copy link
Member

@junhaoliao junhaoliao commented Feb 23, 2024

⚠️ DO NOT MERGE YET: work in progress

References

Description

  1. Install @vscode/webview-ui-toolkit as a dependency.
  2. Replace UI elements with the ones in [@vscode/webview-ui-toolkit]
    (https://github.com/microsoft/vscode-webview-ui-toolkit/).
  3. Address direct concerns raised in Issue The "<=" in verbosity selection is confusing #8 . The proposed slider implementation in the Issue will be addressed separately.

Validation performed

@junhaoliao
Copy link
Member Author

@Henry8192 Kindly take over if you have time.
Please help setting CSS variables (prefixed with --) in the ThemeContextProvider in the format that @vscode/webview-ui-toolkit elements can recognize.

@junhaoliao
Copy link
Member Author

Current look

image
image
image

@junhaoliao
Copy link
Member Author

Closing this PR as the changes were made to a deprecated version of the log viewer. The functionality / improvements introduced here has already been implemented in the new version of the log viewer, which replaced the codebase in PR #101.

@junhaoliao junhaoliao closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant