-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint: Add support for CSS stylesheets in linting workflow. #66
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
24a30ab
Add Stylelint and Prettier configuration for CSS stylesheets.
junhaoliao 653e71b
Update lint scripts to include CSS checks and fixes.
junhaoliao c1e9aa6
Add GitHub action problem matcher for Stylelint.
junhaoliao 64a751c
Fix file-matcher remove path.
junhaoliao c95c20c
Remove path from `remove-matcher`.
junhaoliao 308c319
Move `continue-on-error` to job meta to allow the job to be marked as…
junhaoliao 8cd6e29
Add back `continue-on-error` on "npm --prefix new-log-viewer/ run lin…
junhaoliao b71d699
typo: Add back `continue-on-error` on "npm --prefix new-log-viewer/ r…
junhaoliao b09f16e
Remove `continue-on-error` and enhance conditional lint checks.
junhaoliao 12a8bab
Always run "ataylorme/eslint-annotate-action@v3".
junhaoliao 2c3c242
Add working directory for "Register Stylelint problem matcher".
junhaoliao 676e929
Move working directory to `run: "npm run lint:css-check"`.
junhaoliao 0a18614
Fix path in "Register Stylelint problem matcher"
junhaoliao e14fd6e
Wrap names with quotes.
junhaoliao 78a859a
Remove unused npm script `lint:ci`.
junhaoliao 764ab4f
Use sed to rename new-log-viewer paths.
junhaoliao d07d9b3
Replace single quote with double for sed.
junhaoliao c1ab8fd
Do sed on stderr as well.
junhaoliao 7706e45
Fix lint step to correctly exit on error.
junhaoliao c7b50fc
Allow match if there's no leading space?
junhaoliao 3de697f
Mark line numbers mandatory.
junhaoliao bb9307d
Correct indices.
junhaoliao ccc8a47
Fix regexp.
junhaoliao 8f420b4
Remove color from stylelint output.
junhaoliao bafc21b
Make leading white spaces optional.
junhaoliao dae94ae
change pattern
junhaoliao 4268be5
add severity.
junhaoliao 94387dc
use github formatter instead
junhaoliao bf6b072
Lint stylesheets.
junhaoliao 64b465a
Remove unused problem matcher.
junhaoliao 64e7197
Add names to lint step actions.
junhaoliao 009f24d
Add back npm script "npm run lint:check".
junhaoliao 5481538
Merge branch 'main' into lint-css
junhaoliao 0c6fa4f
Merge branch 'main' into lint-css
junhaoliao 52beffc
Reformat CSS files.
junhaoliao b6db9a1
Merge branch 'y-scope:main' into lint-css
junhaoliao dbd2e87
Simplify lint scripts - Apply suggestions from code review
junhaoliao c597457
Update lint script configurations.
junhaoliao c0d4b71
Simplify lint workflow.
junhaoliao fff19ae
Update lint script and GitHub workflow for CI.
junhaoliao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
tabWidth: 4 | ||
useTabs: false | ||
singleQuote: false | ||
quoteProps: consistent | ||
printWidth: 100 | ||
endOfLine: lf |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"extends": [ | ||
"stylelint-config-standard", | ||
"stylelint-config-clean-order/error", | ||
"stylelint-prettier/recommended" | ||
] | ||
} |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
.menu-bar { | ||
display: flex; | ||
flex-direction: row; | ||
height: var(--ylv-status-bar-height); | ||
align-items: center; | ||
height: var(--ylv-status-bar-height); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,14 @@ | ||
.status-bar { | ||
align-items: center; | ||
position: absolute; | ||
bottom: 0; | ||
|
||
display: flex; | ||
position: absolute; | ||
align-items: center; | ||
|
||
width: 100%; | ||
} | ||
|
||
.status-message { | ||
padding-left: 8px; | ||
flex-grow: 1; | ||
padding-left: 8px; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the parallel might be slightly more convenient, but maybe could cause issues if the linters touch the same files? If they don't, im okay with it. If they do, maybe just use sequential to be safer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supposedly no at the moment. ESLint would only look into js, jsx, ts, and tsx files and we're asking Stylelint to look only into css files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay ltgm