-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new-log-viewer: Add log query support in StateContextProvider
.
#80
Merged
Merged
Changes from 28 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
49bd9a4
query log structure demo (won't work)
Henry8192 5b48fd3
clean up queryLog
Henry8192 7a777ee
various changes
Henry8192 fdd761a
finish draft of query log
Henry8192 5e4571a
queryResults should useRef
Henry8192 6be07e9
add test query icon to menubar
Henry8192 908ee7a
fix query log button, query logs now appear properly in console
Henry8192 da20db4
remove console logs, rename handleChunkResult to chunkResultsHandler …
Henry8192 5bf7df1
remove console logs in debugging
Henry8192 9a3cca9
address suggested changes in pr
Henry8192 8aa0c14
add parameters for queryLogs()
Henry8192 38fe8e1
address part of the suggestions in code review
Henry8192 fb14c88
minor fixes
Henry8192 47c2b82
Merge branch 'main' into log-query
Henry8192 1286879
address suggestions from review after merge
Henry8192 ea6b1ee
Merge branch 'main' into log-query
Henry8192 7ed8baf
use Map instead of Object for query results
Henry8192 46fe49f
fix queryResults not showing issue
Henry8192 9706bd0
provide queryResults in StateContextProvider.tsx
Henry8192 8e91e83
fix lint errors
Henry8192 8f60afc
fix lint docstring
Henry8192 3de7f80
Apply suggestions from code review
Henry8192 3c6c53d
Apply suggestions from code review
Henry8192 e04f169
address rest of the comments
Henry8192 e3913d5
fix lint comment warning
Henry8192 b732607
Update new-log-viewer/src/utils/config.ts
Henry8192 45e5e61
Apply suggestions from code review
Henry8192 142275e
apply suggestions
Henry8192 24e86c8
Apply suggestions from code review
Henry8192 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider refactoring the QUERY_RESULT case for clarity and robustness
The implementation of the
QUERY_RESULT
case is functional, but there are opportunities for improvement:v
for better readability.Map
methods.Here's a suggested refactor:
This refactored version improves readability, simplifies the logic, and adds basic error checking.