-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new-log-viewer: Finish support for filtering by log-level and associated refactoring. #89
Merged
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
9f002a8
first draft
davemarco f66481f
small changes
davemarco 8edcbf6
small change
davemarco 275edc0
clean up stuff
davemarco 1accf00
some cleanup
davemarco 75b5dec
move to index from num
davemarco 4d79444
more changes
davemarco e6fc92f
things seem to work
davemarco 5915bd1
fix lint
davemarco a1983d5
small change
davemarco e3b2b36
small changes
davemarco 03f1670
Apply suggestions from code review
davemarco e904a28
Merge branch 'integrate' of github.com:davemarco/yscope-log-viewer-fo…
davemarco b112382
small change
davemarco e7ad6eb
clean up state context code
davemarco c13df92
fix lint
davemarco 2cc0803
restructure to improve readability
davemarco 04b2515
remove less old functions
davemarco a420d7e
cleanup
davemarco 914a188
lint fix
davemarco 45c2e42
small change
davemarco aec63d5
small change
davemarco 934c7c6
Apply suggestions from code review
davemarco e4e4aee
local changes
davemarco 26b0bf3
Merge branch 'integrate' of github.com:davemarco/yscope-log-viewer-fo…
davemarco 6528c56
junhao review
davemarco e53a904
fix comments
davemarco 3016d14
small change
davemarco 93a46f9
fix lint
davemarco 807066b
change to active num events
davemarco d03da58
move use Effect
davemarco dd9c92e
add decoder options
davemarco a87a9fc
Apply suggestions from code review
davemarco a4f7a0f
Apply suggestions from code review
davemarco b1e26e2
Apply suggestions from code review
davemarco ae97ab3
kirk comment
davemarco bdfd2e0
change falsy value from 0 to null for log event num
davemarco 80ccfec
change to numActiveEvents
davemarco 963cbd5
add concept of activeLogCollectionEvent
davemarco 0808a7b
remove decoder options
davemarco 6551edf
fix lint
davemarco 217693a
change comment
davemarco 6488bf8
small change
davemarco edbf7e1
Apply suggestions from code review
davemarco eb706d3
kirk review
davemarco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Include 'logLevelFilter' value in error message for better debugging
To enhance the clarity of the error message when setting the log level filter fails, consider including the value of
logLevelFilter
. This provides more context and aids in debugging.Apply this diff to improve the error message:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
silly rabbit tricks are for kids. The log level filter is not printable. I think its okay as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davemarco, understood. Thank you for the clarification.
(_/)
( •︵•)
/ \
✏️ Learnings added