Implementing mandatory uncaught exception logging on loader tasks. #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-mclawhorn
force-pushed
the
ForcingExceptionHandlingOnLoadTasks
branch
from
4afdf96 to
6e29923
Compare
QubitPi
suggested changes
Oct 17, 2017
| private static final Logger LOG = LoggerFactory.getLogger(LoadTask.class); | ||
| public static final String LOAD_TASK_ERROR_FORMAT = "Exception while running %s: %s"; |
There was a problem hiding this comment.
Move it to ErrorMessageFormat?
|
|
||
|
|
||
| def "Test error gets logged on failed test"() { | ||
| setup: |
| } | ||
| } | ||
|
|
||
|
|
| def "Test error gets logged on failed test"() { | ||
| setup: | ||
| setup: "Instantiate a task scheduler" | ||
| ObjectMapper MAPPER = new ObjectMappersSuite().getMapper() |
There was a problem hiding this comment.
Looks like MAPPER is unused
| setup: "Instantiate a task scheduler" | ||
| ObjectMapper MAPPER = new ObjectMappersSuite().getMapper() | ||
|
|
||
|
|
|
|
||
| class FailingTestLoadTask extends LoadTaskSpec.OneOffTestLoadTask { | ||
|
|
||
|
|
CHANGELOG.md
Outdated
| @@ -74,6 +74,11 @@ Current | |||
|
|
|||
|
|
|||
| ### Changed: | |||
|
|
|||
| - [Added mandatory logging for LoadTask errors] | |||
|
|
||
| TaskScheduler scheduler = new TaskScheduler(2) | ||
| LoadTask<Boolean> loader = new FailingTestLoadTask(expectedDelay) | ||
| loader.setFuture( |
| scheduler.schedule( | ||
| loader, | ||
| 1, | ||
| TimeUnit.MILLISECONDS |
|
|
||
| expect: | ||
| loader.failed | ||
| logAppender.getMessages().find { it.contains(/UNIQUE_VALUE_1/) } |
There was a problem hiding this comment.
Change "UNIQUE_VALUE_1" to FailingTestLoadTask.UNIQUE_VALUE_1 for better maintainability?
QubitPi
approved these changes
Oct 20, 2017
michael-mclawhorn
force-pushed
the
ForcingExceptionHandlingOnLoadTasks
branch
from
a8006ad to
8a56af3
Compare
michael-mclawhorn
force-pushed
the
ForcingExceptionHandlingOnLoadTasks
branch
from
8a56af3 to
46a55a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding error logging on loader tasks.