add more tests

yahoo · Oct 30, 2020 · 9e1a1a1 · 9e1a1a1
1 parent 532c6aa
commit 9e1a1a1
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/status/status_test.go b/status/status_test.go
@@ -93,7 +93,7 @@ func TestMetricsFunc(t *testing.T) {
 	mg.Dec()
 	assert.Equal(t, uint64(0), mg.Value)
 	mg.Set(55)
-	assert.Equal(t, uint64(55), mg.Value)
+	assert.Equal(t, uint64(55), mg.Get())
 
 	mc := NewCounter("test_errors_total", "")
 	assert.Equal(t, uint64(0), mc.Value)
@@ -102,7 +102,7 @@ func TestMetricsFunc(t *testing.T) {
 	mc.Dec()
 	assert.Equal(t, uint64(1), mc.Value)
 	mc.Set(5)
-	assert.Equal(t, uint64(1), mc.Value)
+	assert.Equal(t, uint64(1), mc.Get())
 
 }
 

diff --git a/telemetry/juniper/jti/jti_test.go b/telemetry/juniper/jti/jti_test.go
@@ -287,6 +287,21 @@ func TestGetLabelsNumber(t *testing.T) {
 	assert.Equal(t, expectedLabels, labels)
 }
 
+func TestGetValue(t *testing.T) {
+	kv := jpb.KeyValue{Value: &jpb.KeyValue_DoubleValue{DoubleValue: 5.5}}
+	assert.Equal(t, 5.5, getValue(&kv))
+	kv = jpb.KeyValue{Value: &jpb.KeyValue_IntValue{IntValue: 5}}
+	assert.Equal(t, int64(5), getValue(&kv))
+	kv = jpb.KeyValue{Value: &jpb.KeyValue_SintValue{SintValue: 5}}
+	assert.Equal(t, int64(5), getValue(&kv))
+	kv = jpb.KeyValue{Value: &jpb.KeyValue_BytesValue{BytesValue: []byte("test")}}
+	assert.Equal(t, []byte("test"), getValue(&kv))
+}
+
+func TestVersion(t *testing.T) {
+	assert.Equal(t, jtiVersion, Version())
+}
+
 func BenchmarkGetLabels(b *testing.B) {
 	r := new(bytes.Buffer)
 	w := new(bytes.Buffer)