Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Error object (#135) #136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SidStraw
Copy link

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Add support for Error object to fixes #135

@etienne-martin
Copy link

Looks good to me

@oceanwap
Copy link

oceanwap commented May 9, 2023

Hey guys, Any idea why this hasn't been merged?

@SidStraw This change is helpful but it doesnt retain the trace of error, it would be amazing to retain the trace of error after deserialization.

@SidStraw
Copy link
Author

SidStraw commented May 9, 2023

Thank you, this suggestion was very helpful.
This is indeed the part that I did not handle.
I will add this logic.

@redonkulus
Copy link
Collaborator

@SidStraw if this is still needed, it will need to rebased since the code has changed since you originally opened this.

@okuryu thoughts on adding this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error objects are serialized to {}
4 participants