-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete key, focus/blur and dropdown improvements for select mode with userInput #1410
Open
Massi-X
wants to merge
15
commits into
yairEO:master
Choose a base branch
from
Massi-X:delete-key-select
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
542e73e
Fix delete key behavior in select mode
Massi-X bea5b66
This should only be applied when userInput == true
Massi-X 2c8ccab
Fix handle of focus/blur and dropdown
Massi-X b35a43e
Fill dropdown after selection
Massi-X 89655c1
Avoid conflict between show and hide
Massi-X 16e6788
Do not advance in select mode
Massi-X 025ad58
Merge branch 'yairEO:master' into delete-key-select
Massi-X 29a8fe9
Revert "Fix delete key behavior in select mode"
Massi-X 2b66604
Fix delete key behavior in select mode
Massi-X e6381e3
Fix broken commit
Massi-X 5ae3c62
Make sure the dropdown closes if no instance is found
Massi-X 8d619fa
Fix commit 2c8ccab
Massi-X 05a1039
Prevent undefined exceptions
Massi-X 95292e2
Revert "Make sure the dropdown closes if no instance is found"
Massi-X 41178f7
Fix checkmark if input is in edit mode
Massi-X File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is needed to prevent the dropdown from closing even when |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1414 depends on this