Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep highlight in select mode #1420

Closed
wants to merge 2 commits into from
Closed

Keep highlight in select mode #1420

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4712039
Keep highlight in select mode
Massi-X Nov 30, 2024
b1f699d
Prevent undefined exceptions
Massi-X Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions src/parts/suggestions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,24 @@ export default {
.then(() => {
if( selectedElm ){
this.dropdown.selectOption(selectedElm)
// highlight next option
selectedElm = this.dropdown.getNextOrPrevOption(selectedElm, !actionUp)
this.dropdown.highlightOption(selectedElm)

if (!isSelectMode) { // highlight next option
selectedElm = this.dropdown.getNextOrPrevOption(selectedElm, !actionUp)
this.dropdown.highlightOption(selectedElm)
} else { // in select mode this never worked. It is also better to keep the highlight in the same spot after selection
setTimeout(() => {
let refs = this.dropdown.getAllSuggestionsRefs()
let selectedElm = null
refs.forEach(elem => {
if (selectedElmData && elem.getAttribute('value') == selectedElmData.value) {
selectedElm = elem
return
}
})

selectedElm != null && this.dropdown.highlightOption(selectedElm, true)
}, 0, selectedElmData) //wait for the dropdown to be redrawn
}
return
}
else
Expand Down Expand Up @@ -494,4 +509,4 @@ export default {
return this.settings.templates.dropdownItem.apply(this, [{...suggestion, mappedValue}, this])
}).join("")
}
}
}