Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases selectOption will fail because parentNode is null. I must say this does not happen on jsbin. To trigger it I did:
Now the first click will fail and I have to click twice, this happens because for some reason
tagElm
(which is equal in this case tothis.state.editing.scope
) refers to an old element that is already removed from the page. Simply skipping thereplaceTag
if parentNode is null is enough to fix thisSee video with error too:
1.mov