Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CivilianUnitAutomation.kt #12742

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EmperorPinguin
Copy link
Contributor

On more crowded maps, the AI has a tendency to have their tiles improved before the great persons start to spawn, and then it can't place academies anymore, which can lead to loss of the unit.

@yairm210
Copy link
Owner

yairm210 commented Jan 4, 2025

Maybe we should check if there's an enemy unit within like 5 tiles? Otherwise this seems like a huge waste

@EmperorPinguin
Copy link
Contributor Author

Maybe we should check if there's an enemy unit within like 5 tiles? Otherwise this seems like a huge waste

That would be better, but sounds like it's more computationally expensive, and might not be able to account for attacks with mounted units in all cases.

@yairm210
Copy link
Owner

yairm210 commented Jan 5, 2025

Great Persons aren't that common, and a 5-tile radius check is much cheaper than the checks we have for e.g. Setters or Workers, which are super common

@EmperorPinguin
Copy link
Contributor Author

Great Persons aren't that common, and a 5-tile radius check is much cheaper than the checks we have for e.g. Setters or Workers, which are super common

Would it make sense to use a radius check for settlers as well then? Ideally, we should be done settling before there are roads or units with more than 2 movement.

@yairm210
Copy link
Owner

yairm210 commented Jan 5, 2025

We already have quite complicated radius checks for settlers, that's my point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants