prevent title schema rewrites for custom titles (#529)

Co-authored-by: Gregor Harlan <[email protected]>
yakamara · Mar 31, 2023 · 8986b39 · 8986b39
1 parent 7343258
commit 8986b39
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/lib/yrewrite/seo.php b/lib/yrewrite/seo.php
@@ -147,21 +147,15 @@ public function getRobotsTag()
 
     public function getTitle()
     {
-        $title_scheme = htmlspecialchars_decode(trim($this->domain->getTitle()));
-        if ('' == $title_scheme) {
-            $title_scheme = self::$title_scheme_default;
+        $title = $this->article->getValue(self::$meta_title_field);
+        if ('' == $title) {
+            $title = htmlspecialchars_decode(trim($this->domain->getTitle()));
         }
-
-        $ytitle = '';
-        if ($this->article && '' != $this->article->getValue(self::$meta_title_field)) {
-            $ytitle = $this->article->getValue(self::$meta_title_field);
-        }
-        if ('' == $ytitle) {
-            $ytitle = $this->article->getValue('name');
+        if ('' == $title) {
+            $title = self::$title_scheme_default;
         }
 
-        $title = $title_scheme;
-        $title = str_replace('%T', $ytitle, $title);
+        $title = str_replace('%T', $this->article->getValue('name'), $title);
         $title = str_replace('%SN', rex::getServerName(), $title);
 
         return $this->cleanString($title);