Skip to content

Commit

Permalink
Remove mysterious clearCachedNode call in JRuby that breaks Blather
Browse files Browse the repository at this point in the history
It was previously described at "weird" and even the original author
cannot remember why it is there. Its presence causes Blather's
Blather::XMPPNode subclass instances to be recreated where they become
generic Nokogiri::XML::Element instances instead.

Closes sparklemotion#1708.
  • Loading branch information
chewi committed Jan 29, 2018
1 parent d35ed46 commit da3c323
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions ext/java/nokogiri/XmlNode.java
Original file line number Diff line number Diff line change
Expand Up @@ -464,9 +464,6 @@ public void relink_namespace(ThreadContext context) {
return;
}

// TODO: this feels kind of weird, why are we clearing the XmlNode
// cache here !!!
clearCachedNode(node);
Element e = (Element) node;

// disable error checking to prevent lines like the following
Expand Down

0 comments on commit da3c323

Please sign in to comment.