-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YALB-898: Metadata: Add favicon
The original implementation disregarded the accordion_items in the component library and rendered them in atomic. This was causing a missing h2 level when no accordion title was present. To fix this, we preprocess the paragraph__accordion_item to inject a new attribute that will hold the heading_level that should be used, defaulting to 3.
…ew layout builder
The video element was passing content.field_heading to the video__heading variable. This was causing evaluations of whether the video__heading was empty to result in false due to it being an array I beleive. Changing this to always attempt to pass the 0th element now causes it to function as expected.
The full field_heading was being passed to the media_grid__heading, causing it to result in a false positive when checking for empty values since it is an array of values. Passing the 0th element allows the media grid to function as intended.
The field_heading array was being passed into the grid, resulting in false positives when evaluating whether it is empty or not. Passing the 0th element now allows the gallery to work as intended. Note: This is only for the overall header.
The modal_item__heading was receiving the array of content.field_heading, resulting in false positives when checking if the head was empty. Changing this to pass the 0th element allows the modal content to function as intended.
…y-fe-empty-heading-being-inserted-when-user-does-not-fill-in-heading-field YALB-1394: Bug: Accessibility (FE)- Empty heading being inserted when user does not fill in heading field
Wool was so close to getting to the correct contrast ratio, but it wasn't quite there. This now allows it to cross that threshold to accomodate A11y.
…-and-editing-a-table-is-visually-and-functionally-broken YALB-1442: WYSIWYG Creating and editing a table is visually and functionally broken
YALB-1407- Bug: Accessibility (FE)- Interactive Media needs roles and tabbing fixes | YALB-1454 - Bug: FE: Quote em dash and name alignment off
YALB-1164 - OPAC: Update admin toolbar icons | 1461 - OPAC: Implement new admin colors and fonts
YALB-1388 - Feedback: Embed Block | YALB-1390 - Remove transparency from banner overlay | YALB-1417 - Bug: Block picker in Posts and Events only have 2 columns compared to 3 on Pages | YALB-1463 - Bug: Content Spotlight Border severely impacts use/placement of Block | YALB-858 - Feedback: Site Name looks too small on mobile
🎉 This PR is included in version 1.17.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release