Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YALB-1450: Link field truncates and breaks long links #342

Merged
merged 2 commits into from
Jul 11, 2023
Merged

YALB-1450: Link field truncates and breaks long links #342

merged 2 commits into from
Jul 11, 2023

Conversation

nJim
Copy link
Contributor

@nJim nJim commented Jul 11, 2023 •
edited by codechefmarc
Loading

YALB-1450: Link field truncates and breaks long links

Description of work

  • Disabled the 'truncation' settings for links fields for the following instances:
    • Block "Button Link", link field
    • Block "Content Spotlight", link field
    • Block "Action Banner", link field
    • Block "Grand Hero", link field
    • Block "Custom Cards", in the "Custom Card" paragraph, link field
    • Block "Callouts", in the "Callout Item" paragraph, link field

Functional testing steps:

@nJim nJim self-assigned this Jul 11, 2023
@nJim
Copy link
Contributor Author

nJim commented Jul 11, 2023

Functionally approved by Alyssa in a meeting.

@nJim nJim requested a review from codechefmarc July 11, 2023 16:38
codechefmarc
codechefmarc approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Approved!

@nJim nJim merged commit a907604 into develop Jul 11, 2023
2 of 3 checks passed
@nJim nJim deleted the YALB-1450-link-truncated branch July 11, 2023 19:42
@nJim nJim mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codechefmarc codechefmarc codechefmarc approved these changes

Assignees

@nJim nJim

Labels
pass code review pass functional review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nJim @codechefmarc