Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YALB-1448: Bug - Media library wont allow item selections #343

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

nJim
Copy link
Contributor

@nJim nJim commented Jul 11, 2023

YALB-1448: Bug - Media library wont allow item selections

Description of work

  • Fixes a bug where site admins can not select media in the media library browser when adding content in a custom block. This is related to a Drupal Core bug that appears in specific configuration of using layout overrides and custom content blocks.
  • To resolve this issue, we must give users explicit permission to add the block. This is strange as users already have these permissions, but somehow this resolved the issues. This is made possible by enabling the module: https://www.drupal.org/project/block_content_permissions
  • Tech debt: Custom blocs are treated as content in a way consistant with nodes starting in Drupal 10.1. Once we upgrade, we can disable this module and use the new core Drupal permissions.

Functional testing steps:

  • Login to Drupal as a site admin
  • Edit the layout of a page and add a 'Video' block. Verify that the user can add an existing video from the media library. Previously this silently failed as there was an 'access denied' on the ajax process.
  • Conduct some sanity checks on other blocks including media focused ones, including a grand hero, imaage, and divider block.

@nJim nJim self-assigned this Jul 11, 2023
@github-actions
Copy link

Visit Site

Created multidev environment pr-343 for yalesites-platform.

@nJim
Copy link
Contributor Author

nJim commented Jul 11, 2023

Functional testing approved by Alyssa in a meeting.

Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Approved!

@nJim nJim merged commit 0149e1c into develop Jul 11, 2023
3 checks passed
@nJim nJim deleted the YALB-1448-media-perms branch July 11, 2023 19:42
@nJim nJim mentioned this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants