Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YALB-956: Bug: Table Properties window doesn't work #361

Merged
merged 1 commit into from
Jul 25, 2023
Merged

YALB-956: Bug: Table Properties window doesn't work #361

merged 1 commit into from
Jul 25, 2023

Conversation

dblanken-yale
Copy link
Contributor

@dblanken-yale dblanken-yale commented Jul 21, 2023 •
edited
Loading

YALB-956: Bug: Table Properties window doesn't work

Using solution proposed from https://www.drupal.org/project/layout_builder_modal/issues/3063834

Description of work

  • Create jQuery to allow interaction of the modal dialog when CKEditor is active
  • Load this script on ys_core

Functional testing steps:

  • Create a page
  • Add a new block: Text
  • Click the "table" icon in the CKEditor window
  • Verify that you can click and modify inputs in the modal that displays

@dblanken-yale dblanken-yale self-assigned this Jul 21, 2023
@github-actions
Copy link

Visit Site

Created multidev environment pr-361 for yalesites-platform.

@dblanken-yale dblanken-yale marked this pull request as ready for review July 21, 2023 18:52
@dblanken-yale dblanken-yale force-pushed the YALB-956-bug-table-properties-window-doesnt-work branch from 14ecdaf to f683b31 Compare July 24, 2023 18:46
codechefmarc
codechefmarc approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on multidev and all works great. Approved!

@dblanken-yale dblanken-yale merged commit 13ea17d into develop Jul 25, 2023
3 checks passed
@dblanken-yale dblanken-yale deleted the YALB-956-bug-table-properties-window-doesnt-work branch July 25, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codechefmarc codechefmarc codechefmarc approved these changes

@nJim nJim Awaiting requested review from nJim

Assignees

@dblanken-yale dblanken-yale

Labels
pass code review pass functional review ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dblanken-yale @codechefmarc