Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout Sections and Profiles #363

Merged
merged 62 commits into from
Aug 21, 2023
Merged

Layout Sections and Profiles #363

merged 62 commits into from
Aug 21, 2023

Conversation

codechefmarc
Copy link
Contributor

@codechefmarc codechefmarc commented Jul 21, 2023

Tickets

Description of work

  • Adds profile content type, associated fields, permissions, and layout section settings
  • Adds meta blocks for pages, posts, events, and profiles
  • Adds contact block for profiles
  • Updates layout builder sections to use new meta blocks for existing pages, events, and posts
  • New settings should also work on new pages, events, and posts

Functional testing steps:

  • Login as a site administrator role - do not test with platform admin or user 1

Pages

  • Enter layout builder on an existing page
  • Verify that there is a title block at the top and that it is not editable
  • Scroll to the bottom of the components and verify that there is an "Add section" button

Screenshot 2023-07-25 at 5 15 05 PM

  • Click the "Add section" button and add a section of type "Two column"
  • Add whatever administrative label you wish and click "Add section" at the bottom
  • Verify that a two column layout was added

Screenshot 2023-07-25 at 5 15 44 PM

  • Add some items to the "Content" region and to the "Sidebar" region of the two column layout.
  • Verify that the only item you can add to the sidebar is "Text"

Events

  • View an existing event
  • Verify that the top "Event Meta" section shows up

Screenshot 2023-07-25 at 5 17 17 PM

  • Enter layout builder
  • Verify that the "Event Meta" section still shows, but is not editable
  • Edit the event (Manage settings toolbar link)
  • Change some information about the event like the dates, "in person/online", and call to action.
  • Save and verify that the new information shows up on the event meta section.
  • Verify that the "Add to calendar" link works correctly

Posts

  • View an existing post
  • Verify that the top "Post Meta" section shows up with a title and date (and author if one is set)

Screenshot 2023-07-25 at 5 18 01 PM

  • Enter layout builder
  • Verify that the "Post Meta" section still shows, but is not editable
  • Edit the post (Manage settings toolbar link)
  • Add an author if one does not exist
  • Save and verify that the author shows up in the post meta section next to the date

Profiles

  • Create a new profile
  • Enter in information for the profile like the department, position, subtitle, email, phone, address, and a photo in the media field.
  • Save and enter layout builder
  • Verify that the profile meta section shows up on top
  • Verify that there is a two column layout on the page already
  • Verify that the contact info section shows up in the sidebar

Screenshot 2023-07-25 at 5 20 54 PM

  • Verify that you can add a new section of either one column or two column
  • Verify that you can remove the contact block if you wish
  • Verify that the only blocks you can add to the sidebar are the contact info and text blocks.
  • Save the layout and verify that the design matches the Figma designs here

nJim and others added 26 commits June 18, 2023 22:08
@github-actions
Copy link

Visit Site

Created multidev environment pr-363 for yalesites-platform.

Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!!!!! Nice job!!!!!

@miketullo95
Copy link
Contributor

@joetower I would say probably no for quick links. I added one and it doesn't look like it could fit even with some changes. Looking at the rest of the list, I feel like the rest of the blocks should be good.

Copy link
Contributor

@joetower joetower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codechefmarc I confirmed that the options for two-column layout primary region now include those outlined in the theming ticket. That looks great, thanks!

I pushed up a fix to the atomic branch for the profile breadcrumbs and left a note in that PR. Please give my change a look. Otherwise this is looking good to me!

@miketullo95
Copy link
Contributor

Quick bug found: I added a second contact info block in the right side, then tried to remove that block (or even the original one) and they cannot be deleted.

@codechefmarc
Copy link
Contributor Author

Great find @miketullo95! I've fixed that issue and it's on the multidev.

@joetower
Copy link
Contributor

joetower commented Aug 9, 2023

@codechefmarc @miketullo95 I pushed a fix to this branch (in Atomic) for the section visual borders.

If you test on this multidev: https://pr-363-yalesites-platform.pantheonsite.io and login and edit this example Profile: https://pr-363-yalesites-platform.pantheonsite.io/node/98/layout, you should see the following:

yalb-node-section-borders.mp4

Please let me know what you think Mike. 👍

@codechefmarc
Copy link
Contributor Author

@joetower - That looks really nice!

@miketullo95
Copy link
Contributor

@joetower agree with marc, this looks great! Quick question, the admin styles for the tabs in /edit on a profile needs updating. Is that suitable for this PR or your other open PR for admin fixes?
Screen Shot 2023-08-11 at 9 17 27 AM

@joetower
Copy link
Contributor

@miketullo95 I pushed a fix for that in a related branch here: #371 (comment)

Please take a look at that comment and let me know what your thoughts are. Thank you!

@miketullo95
Copy link
Contributor

oooh, i see! apologies, both look great! 👍

@codechefmarc codechefmarc merged commit d8099cc into develop Aug 21, 2023
3 checks passed
@codechefmarc codechefmarc deleted the YALB-85-profiles branch August 21, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants