Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YALB-1388 - Feedback: Embed Block | YALB-1390 - Remove transparency from banner overlay | YALB-1417 - Bug: Block picker in Posts and Events only have 2 columns compared to 3 on Pages | YALB-1463 - Bug: Content Spotlight Border severely impacts use/placement of Block | YALB-858 - Feedback: Site Name looks too small on mobile #365

Merged
merged 3 commits into from
Jul 31, 2023
Merged

YALB-1388 - Feedback: Embed Block | YALB-1390 - Remove transparency from banner overlay | YALB-1417 - Bug: Block picker in Posts and Events only have 2 columns compared to 3 on Pages | YALB-1463 - Bug: Content Spotlight Border severely impacts use/placement of Block | YALB-858 - Feedback: Site Name looks too small on mobile #365

merged 3 commits into from
Jul 31, 2023

Conversation

joetower
Copy link
Contributor

@joetower joetower commented Jul 27, 2023 •
edited
Loading

YALB-1388 - Feedback: Embed Block | YALB-1390 - Remove transparency from banner overlay | YALB-1417 - Bug: Block picker in Posts and Events only have 2 columns compared to 3 on Pages | YALB-1463 - Bug: Content Spotlight Border severely impacts use/placement of Block | YALB-858 - Feedback: Site Name looks too small on mobile

Test here: yalesites-org/component-library-twig#276

Description:

  • In this branch, a page-specific hook was removed and a new hook was added to make sure our custom library (and css) loads for all content types. This will make sure the modal grid of components, when adding a block, is consistently presented in 3-columns. Thank you, Marc. (Marc really did this work).

@joetower joetower self-assigned this Jul 27, 2023
@github-actions
Copy link

Visit Site

Created multidev environment pr-365 for yalesites-platform.

@joetower joetower changed the title fix(yalb-1390): multidev generation only **testing only - don't merge** YALB-1388 - Feedback: Embed Block | YALB-1390 - Remove transparency from banner overlay | YALB-1417 - Bug: Block picker in Posts and Events only have 2 columns compared to 3 on Pages | YALB-1463 - Bug: Content Spotlight Border severely impacts use/placement of Block | YALB-858 - Feedback: Site Name looks too small on mobile Jul 27, 2023
@joetower joetower marked this pull request as ready for review July 27, 2023 19:26
dblanken-yale
dblanken-yale approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joetower and @codechefmarc
Works great in the other PR! Nice job!

@nJim nJim merged commit 6c6801f into develop Jul 31, 2023
3 checks passed
@nJim nJim deleted the yalb-1390-1463 branch July 31, 2023 03:17
@nJim nJim mentioned this pull request Jul 31, 2023
Merged
@nJim nJim mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nJim nJim nJim approved these changes

@dblanken-yale dblanken-yale dblanken-yale approved these changes

@codechefmarc codechefmarc Awaiting requested review from codechefmarc

Assignees

@joetower joetower

Labels
pass code review pass functional review ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joetower @nJim @dblanken-yale