-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YSP-559: Upgrade Node Packages #679
base: develop
Are you sure you want to change the base?
Conversation
Created multidev environment pr-679 for yalesites-platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joetower - I tested this locally - switched to the branch for all three repos, deleted node_modules
folder, and then had to install the new node on my computer nvm install 20.14.0
and then ran nvm use
and then npm install
for each repo.
All of that worked!
Then, I ran through a normal setup of the site like I usually do for local dev: npm run build-with-assets
and then npm run local:cl-dev
. The first part worked. The second part worked for the most part, but got hung up after the message webpack 5.92.0 compiled successfully in 13644 ms
and didn't complete. No errors though.
After realizing the branch on Atomic got reset to a commit hash of some sort, I put that back to this branch (YSP-559-update-npm-packages
) and re-ran npm run local:cl-dev
and all worked great! A lot less deprecation messages now, though there still are some that are left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I ran into a similar issue as @codechefmarc; I had a question for him so I could learn how he got it all working with just npm run setup
without having to point to forked branches. I was able to get it all working after a npm run setup
and then git-checkout
on those specific branches--no errors. Since this does similar to what setup does, I think this will work and I trust Marc's review. 😁
Again, nice work getting all of these working.
ca1ac60
to
6299e8a
Compare
Created multidev environment pr-679 for yalesites-platform. |
Got it up to date with latest release and got ys_links working in this one for now till we migrate out. Would appreciate another PR look. We're going to wait for just a little to get this in since we need some ai_engine releases out before it can go in. Hoping after Monday we can get it in. |
This should be rebuilt with the latest release changes and ys_links works now. Please re-review. |
1af22bb
to
96a0bd1
Compare
96a0bd1
to
d83751f
Compare
@dblanken-yale is there any specific use cases we should focus on here? maybe treat this as a kinda release and try all most common features? |
Yes, since this affects all blocks, we'll want to make sure all is looking well in all of them. |
YSP-559: Upgrade Node Packages - Component Library
YSP-485: Card external link styling adds spacing with the right amount of characters
YSP-689: Mega footer - link color and responsive
Description of work
Functional testing steps:
node_modules
directories from each repository - component library and atomic, and runningnvm use
and/ornpm install
to use node 20, thennpm install
on each to install the updated packages.