Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YSP-559: Upgrade Node Packages #679

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

joetower
Copy link
Contributor

@joetower joetower commented Jun 18, 2024

YSP-559: Upgrade Node Packages - Component Library

YSP-485: Card external link styling adds spacing with the right amount of characters

YSP-689: Mega footer - link color and responsive

Description of work

  • Updates node to v20
  • Updates tooling to use node 20
  • Updates packages
  • Utilize linkpurpose
  • Fix mega footer link color
  • Fix single card event date color

Functional testing steps:

  • Verify there are no glaring issues when navigating https://pr-679-yalesites-platform.pantheonsite.io/
  • Locally you can test by removing all the node_modules directories from each repository - component library and atomic, and running nvm use and/or npm install to use node 20, then npm install on each to install the updated packages.
  • For Card external link styling adds spacing with the right amount of characters, I clones their page for us to test against:
    • Test Page 1
      • Resize and notice that the arrow no longer hangs off the side and stays with "Browser"
    • Test Page 2
      • Resize and notice that the arrow now follows the last name and doesn't dangle.
  • Ensure mega footer is selected for the site and add a link inside of the content (make categories of links also)
    • Verify that when looking at the link in the page, it has proper contrast for visited and non-visited
    • Ensure when resizing that links stack

@joetower joetower self-assigned this Jun 18, 2024
Copy link

Visit Site

Created multidev environment pr-679 for yalesites-platform.

@joetower joetower changed the title Ysp 559 update npm packages YSP-559: Upgrade Node Packages - Component Library Jun 18, 2024
@joetower joetower changed the title YSP-559: Upgrade Node Packages - Component Library YSP-559: Upgrade Node Packages Jun 18, 2024
@joetower joetower marked this pull request as ready for review June 18, 2024 18:24
@joetower joetower requested a review from a team as a code owner June 18, 2024 18:24
Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joetower - I tested this locally - switched to the branch for all three repos, deleted node_modules folder, and then had to install the new node on my computer nvm install 20.14.0 and then ran nvm use and then npm install for each repo.

All of that worked!

Then, I ran through a normal setup of the site like I usually do for local dev: npm run build-with-assets and then npm run local:cl-dev. The first part worked. The second part worked for the most part, but got hung up after the message webpack 5.92.0 compiled successfully in 13644 ms and didn't complete. No errors though.

After realizing the branch on Atomic got reset to a commit hash of some sort, I put that back to this branch (YSP-559-update-npm-packages) and re-ran npm run local:cl-dev and all worked great! A lot less deprecation messages now, though there still are some that are left.

Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I ran into a similar issue as @codechefmarc; I had a question for him so I could learn how he got it all working with just npm run setup without having to point to forked branches. I was able to get it all working after a npm run setup and then git-checkout on those specific branches--no errors. Since this does similar to what setup does, I think this will work and I trust Marc's review. 😁

Again, nice work getting all of these working.

Copy link

Visit Site

Created multidev environment pr-679 for yalesites-platform.

@dblanken-yale dblanken-yale requested review from kara-franco and atiddei and removed request for nJim August 21, 2024 13:09
@dblanken-yale
Copy link
Contributor

Got it up to date with latest release and got ys_links working in this one for now till we migrate out. Would appreciate another PR look. We're going to wait for just a little to get this in since we need some ai_engine releases out before it can go in. Hoping after Monday we can get it in.

@dblanken-yale dblanken-yale self-assigned this Aug 21, 2024
@dblanken-yale
Copy link
Contributor

This should be rebuilt with the latest release changes and ys_links works now. Please re-review.

@miketullo95
Copy link
Contributor

@dblanken-yale is there any specific use cases we should focus on here? maybe treat this as a kinda release and try all most common features?

@dblanken-yale
Copy link
Contributor

Yes, since this affects all blocks, we'll want to make sure all is looking well in all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants