Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YSP-346: Add pronoun field #768

Merged
merged 2 commits into from
Oct 1, 2024
Merged

YSP-346: Add pronoun field #768

merged 2 commits into from
Oct 1, 2024

Conversation

dblanken-yale
Copy link
Contributor

@dblanken-yale dblanken-yale commented Sep 23, 2024

YSP-346: Add pronoun field

Other work needing review in:

Description of work

  • Adds pronoun field to profile
  • Allows display of this profile field in rendering

Functional testing steps:

  • Add a profile
  • Observe an input for Pronoun
  • When filling this field out, observe it shows on rendering of the profile

Copy link

Visit Site

Created multidev environment pr-768 for yalesites-platform.

@miketullo95
Copy link
Contributor

first review back! woohoo! this looks great, super excited to get this work through. One note, idk if it was discussed... do we want pronouns to show through view previews? The profile pages look great with the pronouns in the meta block 👍

@dblanken-yale
Copy link
Contributor Author

Woohoo! Welcome back @miketullo95!!! Actually no discussion was made yet; I more took this on since I had a little time over the weekend. Was more to spark conversation on what we should do with it. I'll see if I can add some meta goodness into that so we can see how it'd look.

@miketullo95
Copy link
Contributor

Woohoo! Welcome back @miketullo95!!! Actually no discussion was made yet; I more took this on since I had a little time over the weekend. Was more to spark conversation on what we should do with it. I'll see if I can add some meta goodness into that so we can see how it'd look.

that would be great! I also don't know if its 100% the correct move (still day 1 back 😅). It could be a setting in the view tool but we may want to not add too much in that tool since it has grown a lot recently.

@dblanken-yale
Copy link
Contributor Author

@miketullo95 Ya we have some discussion and need your expertise on some view guidance in some other areas, and yes, it's about to get larger, so we want to minimize as much as we can I think.

@miketullo95
Copy link
Contributor

@dblanken-yale we missed this in our bi-weekly but we should p2 it for tuesday! 😄

@dblanken-yale
Copy link
Contributor Author

@miketullo95 Good call; ya again this was more a jumpstart since we didn't really talk through any specifics. Just took it with my own idea of it so we could see something and make some decisions. 😁 Let's try to on Tuesday.

@miketullo95
Copy link
Contributor

@dblanken-yale definitely agree! I think even a safe bet is to approve/merge with whats in the PR now and if users want more control over this field via views, we can add that as a new feature.

@dblanken-yale dblanken-yale merged commit 38ae704 into develop Oct 1, 2024
3 checks passed
@dblanken-yale dblanken-yale deleted the YSP-346-pronoun branch October 1, 2024 19:36
@yalesites yalesites mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants