-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YSP-346: Add pronoun field #768
Conversation
Created multidev environment pr-768 for yalesites-platform. |
first review back! woohoo! this looks great, super excited to get this work through. One note, idk if it was discussed... do we want pronouns to show through view previews? The profile pages look great with the pronouns in the meta block 👍 |
Woohoo! Welcome back @miketullo95!!! Actually no discussion was made yet; I more took this on since I had a little time over the weekend. Was more to spark conversation on what we should do with it. I'll see if I can add some meta goodness into that so we can see how it'd look. |
that would be great! I also don't know if its 100% the correct move (still day 1 back 😅). It could be a setting in the view tool but we may want to not add too much in that tool since it has grown a lot recently. |
@miketullo95 Ya we have some discussion and need your expertise on some view guidance in some other areas, and yes, it's about to get larger, so we want to minimize as much as we can I think. |
@dblanken-yale we missed this in our bi-weekly but we should p2 it for tuesday! 😄 |
@miketullo95 Good call; ya again this was more a jumpstart since we didn't really talk through any specifics. Just took it with my own idea of it so we could see something and make some decisions. 😁 Let's try to on Tuesday. |
@dblanken-yale definitely agree! I think even a safe bet is to approve/merge with whats in the PR now and if users want more control over this field via views, we can add that as a new feature. |
9eac230
to
f8b8047
Compare
YSP-346: Add pronoun field
Other work needing review in:
Description of work
Functional testing steps: