YSP-690: Deprecation of parameters with default values order #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a $cachable which was not even in the signature of options_allowed_values, yet we were passing something in that then wasn't even being used. This lets it match the signature found at: https://api.drupal.org/api/drupal/core%21modules%21options%21options.module/function/options_allowed_values/10
dblanken-yale
changed the title
|
Created multidev environment pr-774 for yalesites-platform. |
vinmassaro
approved these changes
Oct 1, 2024
dblanken-yale
added
pass code review
pass functional review
and removed
needs review
labels
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YSP-690: Deprecation of parameters with default values order
We had a $cachable which was not even in the signature of options_allowed_values, yet we were passing something in that then wasn't even being used. This lets it match the signature found at:
https://api.drupal.org/api/drupal/core%21modules%21options%21options.module/function/options_allowed_values/10
Description of work
$cachablereference as we weren't using it anyway and it's not in the D10 signatureFunctional testing steps: