Set media page title.

yamat47 · Aug 14, 2024 · abe16ac · abe16ac
1 parent 8e5d0ed
commit abe16ac
Show file tree

Hide file tree

Showing 9 changed files with 53 additions and 3 deletions.
diff --git a/app/app/controllers/media/game_schedules_controller.rb b/app/app/controllers/media/game_schedules_controller.rb
@@ -7,11 +7,11 @@ class GameSchedulesController < ApplicationController
     before_action :ensure_season_param
 
     def index
-      season = Season.find_by!(short_name: params[:season])
+      @season = Season.find_by!(short_name: params[:season])
 
       game_schedules = GameSchedule.start_at_ordered
                                    .game_field_ordered
-                                   .where(season:)
+                                   .where(season: @season)
                                    .preload(:home_team, :visitor_team, :game_field, :tournament)
 
       # group by date.

diff --git a/app/app/helpers/media/seo_helper.rb b/app/app/helpers/media/seo_helper.rb
@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+module Media
+  module SeoHelper
+    BASE_PAGE_TITLE = '関東学生フットボールクラブ連盟 公式サイト'
+
+    def media_page_title(title)
+      [title, BASE_PAGE_TITLE].filter_map(&:presence).join('｜')
+    end
+  end
+end
diff --git a/app/app/views/layouts/media/application.html.haml b/app/app/views/layouts/media/application.html.haml
@@ -1,7 +1,8 @@
 !!!
 %html
   %head
-    %title KcffMatchHub
+    %title
+      = media_page_title(content_for(:title))
     %meta{ content: 'width=device-width,initial-scale=1', name: 'viewport' }
     = csrf_meta_tags
     = csp_meta_tag

diff --git a/app/app/views/media/game_fields/index.html.haml b/app/app/views/media/game_fields/index.html.haml
@@ -1,6 +1,7 @@
 :ruby
   add_breadcrumb t('view.media.breadcrumbs.root'), root_path
   add_breadcrumb t('view.media.breadcrumbs.game_fields.index')
+  content_for(:title, t('view.media.page_title.game_fields.index'))
 
 .media-list
   .media-list__title

diff --git a/app/app/views/media/game_schedules/index.html.haml b/app/app/views/media/game_schedules/index.html.haml
@@ -1,6 +1,7 @@
 :ruby
   add_breadcrumb t('view.media.breadcrumbs.root'), root_path
   add_breadcrumb t('view.media.breadcrumbs.game_schedules.index')
+  content_for(:title, t('view.media.page_title.game_schedules.index', season: @season.full_name))
 
 .media-list
   .media-list__title

diff --git a/app/app/views/media/notices/show.html.haml b/app/app/views/media/notices/show.html.haml
@@ -2,6 +2,7 @@
   add_breadcrumb t('view.media.breadcrumbs.root'), root_path
   add_breadcrumb t('view.media.breadcrumbs.notices.index'), notices_path
   add_breadcrumb @notice.title
+  content_for(:title, @notice.title)
 
 .media-list
   .media-list__content

diff --git a/app/app/views/media/teams/index.html.haml b/app/app/views/media/teams/index.html.haml
@@ -1,6 +1,7 @@
 :ruby
   add_breadcrumb t('view.media.breadcrumbs.root'), root_path
   add_breadcrumb t('view.media.breadcrumbs.teams.index')
+  content_for(:title, t('view.media.page_title.teams.index'))
 
 .media-list
   .media-list__title

diff --git a/app/config/locales/ja.yml b/app/config/locales/ja.yml
@@ -372,6 +372,15 @@ ja:
           start_at: K.O.
           tournament: 大会
           teams: 対戦チーム
+      page_title:
+        game_fields:
+          index: 試合会場
+        teams:
+          index: 所属チーム
+        game_schedules:
+          index: 日程・結果（%{season}）
+        notices:
+          index: お知らせ
       breadcrumbs:
         root: トップページ
         game_fields:

diff --git a/app/spec/helpers/media/seo_helper_spec.rb b/app/spec/helpers/media/seo_helper_spec.rb
@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe Media::SeoHelper do
+  describe '#media_page_title' do
+    context 'when title is nil' do
+      subject { helper.media_page_title(nil) }
+
+      it { is_expected.to eq '関東学生フットボールクラブ連盟 公式サイト' }
+    end
+
+    context 'when title is empty string' do
+      subject { helper.media_page_title('') }
+
+      it { is_expected.to eq '関東学生フットボールクラブ連盟 公式サイト' }
+    end
+
+    context 'when title is present' do
+      subject { helper.media_page_title('タイトル') }
+
+      it { is_expected.to eq 'タイトル｜関東学生フットボールクラブ連盟 公式サイト' }
+    end
+  end
+end