Open ended streams need document end marker #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 27, 2019
perlpunk
changed the title
|
See #50 for a followup |
...like block scalars with the `|+` indicator for keeping trailing empty lines
perlpunk
force-pushed
the
perlpunk/open-ended
branch
from
3874fd9 to
55e8221
Compare
perlpunk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...like block scalars with the
|+indicator for keeping trailingempty lines
This document, if the last in the stream:
should be emitted as:
pyyaml and ruamel are doing this correctly (libyaml will do after the next release)
But there's room for discussion:
Arguably, this rule should also apply to all other documents in the stream, because a single document in a stream should be the same as the document alone.
But neither pyyaml nor ruamel currently output a
...in this case:I suggest to fix those two cases for now and discuss about the other use case then.