Fix a memory leak in inodesByTime (evicted inodes were not removed fr…

…om the map)

internal/file.go

@@ -1988,6 +1988,7 @@ func (inode *Inode) resetCache() {
 	inode.SetCacheState(ST_CACHED)
 	// Invalidate metadata entry
 	inode.SetAttrTime(time.Time{})
+	inode.SetExpireTime(time.Time{})
 }
 
 func (inode *Inode) FlushSmallObject() {

internal/goofys.go

@@ -857,7 +857,8 @@ func (fs *Goofys) MetaEvictor() {
 		}
 		// Try to keep the number of cached inodes under control %)
 		fs.mu.RLock()
-		toEvict := (len(fs.inodes)-fs.flags.EntryLimit)*2
+		totalInodes := len(fs.inodes)
+		toEvict := (totalInodes-fs.flags.EntryLimit)*2
 		if toEvict < 0 {
 			fs.mu.RUnlock()
 			retry = false
@@ -895,10 +896,7 @@ func (fs *Goofys) MetaEvictor() {
 				seen[id] = true
 			}
 		}
-		fs.mu.RLock()
-		totalInodes := len(fs.inodes)
 		retry = len(scan) >= toEvict && totalInodes > fs.flags.EntryLimit
-		fs.mu.RUnlock()
 		atomic.AddInt64(&fs.stats.evicts, int64(evicted))
 		if len(scan) > 0 {
 			log.Debugf("metadata cache: alive %v, scanned %v, evicted %v", totalInodes, len(scan), evicted)