-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: fix metadata-token-service.ts #135
base: master
Are you sure you want to change the base?
Changes from 1 commit
b47248b
1492b04
c59ff46
a6e76a5
213cbbb
b97b75b
1386241
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,6 +50,7 @@ | |
"import/no-extraneous-dependencies": ["error", { | ||
"devDependencies": true | ||
}], | ||
"import/no-cycle": "off" | ||
"import/no-cycle": "off", | ||
"linebreak-style": "off" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Zork33 давай, пожалуйста, вернем это правило, с учетом того что Коля выше описал. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. это правило ломает разработку под windows - lint начинает выглядеть вот так, если его возвращать, то хорошо бы придумать как это обойти под виндой. вариант чтобы под виндой были просто lf переносы не встречал. при этом, как я уже говорил, git под виндой сам нормализует crlf -> lf при комите. Есть ли реальная проблема? |
||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
.idea | ||
node_modules | ||
dist | ||
coverage |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import * as path from 'path'; | ||
import config from './jest'; | ||
|
||
/* | ||
* For a detailed explanation regarding each configuration property and type check, visit: | ||
* https://jestjs.io/docs/configuration | ||
*/ | ||
|
||
export default { | ||
...config, | ||
collectCoverage: true, | ||
collectCoverageFrom: [ | ||
'**/*.{js,ts}', | ||
'!generated/**', | ||
], | ||
coverageDirectory: '../coverage', | ||
}; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/* | ||
|
||
Issuance of tokens shall be in accordance with the following rules | ||
|
||
When accessing APIs of other Cloud services (including the database), services should follow the standard rules of | ||
working with tokens recommended by the documentation: | ||
|
||
- a token is issued in the way most appropriate for this service: for example, it can be a metadata service for SVM, Token Agent | ||
for iron hosts or JWT for services hosted outside the Cloud perimeter | ||
|
||
- the application does not start (does not start accepting requests) until its system SA token has been successfully issued; | ||
the application does not start if the token issued at the moment of start is valid for less than 15 minutes; | ||
|
||
- the token issued at start time is used for a time equal to at least 10% of the difference between expires_at and the time the token was issued; | ||
|
||
- a token that has been used within the time specified in the previous paragraph is subject to update: the application starts | ||
a background process that reissues the token of its system SA, while all current requests continue to be made with the | ||
cached token (thus, in case of any problems with token reissue, 90% of the token's lifetime will be left to notice and | ||
correct the situation); | ||
|
||
- it is recommended that applications have a system SA token usage time monitor, which should be lit if the token lifetime | ||
approaches 20% of the difference between expires_at and the token's expiration time. | ||
|
||
*/ | ||
|
||
export const MAX_ATTEMPTS_NUMBER_TO_GET_TOKEN_IN_INITIALIZE = 5; | ||
|
||
export const TOKEN_MINIMUM_LIFETIME_MARGIN_MS = 15 * 60 * 1000; | ||
|
||
export const TOKEN_LIFETIME_LEFT_TO_REFRESH_PCT = 90; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turn this back on, please. And fix linebreaks in the IDE settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I'm developing on Windows, if I don't enable this option, I get an error on every line ) However, any windows git client converts crlf to lf during any git commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said, you should fix it in the IDE settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а кто нибуть на практике пробовал так работать? потому что для windows crlf возникает на всех шагах - когда файлы из git приходят, когда редактируешь любым не специально настроенным редактором, генераторы кода тоже с таким переносом пишут. так что просто настройки IDE задачу увы не решают