-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Assistant sdk #178
base: alpha
Are you sure you want to change the base?
[WIP] Assistant sdk #178
Conversation
7da73cd
to
43f3d4f
Compare
a686c55
to
c0b16ac
Compare
@@ -26,7 +26,6 @@ | |||
"import/prefer-default-export": "off", | |||
"comma-dangle": ["error", "always-multiline"], | |||
"indent": "off", | |||
"@typescript-eslint/indent": ["error", 4], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это правило prettier'ом хэндлится?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
не знаю что это за правило, случайно удалил
@@ -16,3 +16,5 @@ export * as thread from './generated/yandex/cloud/ai/assistants/v1/threads/threa | |||
export * as threadService from './generated/yandex/cloud/ai/assistants/v1/threads/thread_service'; | |||
export * as user from './generated/yandex/cloud/ai/assistants/v1/users/user'; | |||
export * as userService from './generated/yandex/cloud/ai/assistants/v1/users/user_service'; | |||
|
|||
export * as SDK from './sdk'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Че т я не очень понял, а откуда оно взялось? Я в proto не вижу каких-либо модулей sdk
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ты про то, что оно появилось в // generated file ?
"ai-assistants-v1", | ||
"ai-dataset-v1", | ||
"ai-files-v1", | ||
"ai-foundation_models-v1", | ||
"ai-foundation_models-v1/sdk", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Кажется избыточным, предыдущий пункт должен включать и текущий тоже.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я вот не уверен, у меня локально даже так ts ругается на sdk - что оно не видит.
Мб у меня локальный линтер с ума сходит из за подмен либ.
Поэтому добавил - чтобы точно быть уверенным, что оно хоть как то в новом релизе прорастет
export * as SDK from './sdk';
No description provided.