Set value of labels in lower case #469
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Savin <[email protected]>
|
it would be really helpful indeed. Hope the dev team could find some time to review the PR. |
PeppaTheC
requested changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings, please consider this PR. I encountered an unexpected behavior - values of any labels are passed in the case in which they were written. However, on the API side there is validation (regex:
/[-_./@0-9a-z]*/), which prohibits the use of upper case.If I understand your codebase correctly, the fix for this is very simple.
I'm sure this PR will be useful for everyone who uses task id from their task trackers in labels, because the most popular ones (Jira/YouTrack/Yandex Tracker) use uppercase as a key.