Make project an OSGI bundle #143
Conversation
| @@ -60,14 +62,6 @@ public void removeFileSet(Distribution distribution, IExtractedFileSet all) { | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean checkDistribution(Distribution distribution) throws IOException { | |||
| if (!LocalArtifactStore.checkArtifact(downloadConfig, distribution)) { | |||
There was a problem hiding this comment.
It looked to me the only reason you used the flapdoodle package was to use the LocalArtifactStore. It seemed to me though that this method was identical to the one in the flapdoodle ArtificatStore class. This means we can just extend the ArtifactStore and override the methods we want to override and remove the need to override the checkDistribution method. This allows us to remove the usage of the flapdoodle package and solve the split package problem.
There was a problem hiding this comment.
@smecsia it looks like all the checks have passed for the pull request. Are you able to review it and merge or offer suggestions? Thanks in advance!
|
Hi guys @alinbrici @jlemay thank you very much for your contribution. Sorry for the late reply, I'm not very much into this project at the moment. Why is this important to make it as an OSGI-ready source-code? Do you have an issue to bundle it as a library? |
|
I do want to bundle this as a library in an osgi container. The way osgi works is it uses the the list of exported packages and imported packages to wire the libraries together. If bundle A exports package P and bundle B imports package P, then bundle B will get the package from bundle A. The issue arrises when 2 bundles export the same package. So if bundle A exports package P and bundle C exports package P, then when B tries to resolve which bundle to get the package P from it doesn't know which bundle to get the package from (A or B). This scenario happens because the flapdoodle dependency already exports the de.flapdoodle.embed.process.store package, so when this library also tries to export it the resolution of that package confuses the osgi container. |
I am looking to make use of this module in an osgi environment. Inorder to make use of this project in an osgi environment it needs to be an osgi bundle. This pull request makes this an osgi bundle. I also made a change to remove the de.flapdoodle.embed.process.store package since that package is exported by the flapdoodle dependency. OSGI has a problem when 2 bundles export the same package (it does not handle split packages well)