fix: poll interval to request Notion #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to know when the export is finished, the poll interval to Notion was set to 50ms. Notion didn't bother this one (I guess they didn't pay attention ever before) but from little time ago, on this very frequent request a 429 is being received. So, as the export use to take from seconds to minutes, was tested than a value of 5000ms is ok and don't bother Notion (for now...).
|
Thanks for the PR. I have also seen the 429 behaviour recently. |
I already tried to set it to 500 ms and didn't work (see here). You're right regarding to the |
Add a property (optional) in the config to set the poll interval to check if the export has finished (default to 2000ms).
Removed as parameter function and make it mandatory in config.
yannbolliger
approved these changes
May 26, 2024
Set poll internal as an optional value in config and added private constant with a default interval value in the case the config one is not provided. Be aware it is used _only_ in a private method
|
Thx for contributing! Just released this: https://github.com/yannbolliger/notion-exporter/releases/tag/v0.6.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to know when the export is finished, the poll interval to Notion was set to 50ms. Notion didn't bother this one (I guess they didn't pay attention ever before) but from little time ago, on this very frequent request a 429 is being received. So, as the export use to take from seconds to minutes, was tested than a value of 5000ms is ok and don't bother Notion (for now...).