Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: arm64 WIN patch for 18.20.6 #72

Merged
merged 1 commit into from
Jan 30, 2025
Merged

fix: arm64 WIN patch for 18.20.6 #72

merged 1 commit into from
Jan 30, 2025

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Jan 29, 2025 •
edited
Loading

Fixes #71

faulpeltz
faulpeltz approved these changes Jan 29, 2025
View reviewed changes
Copy link

@faulpeltz faulpeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work because it was only set for Win + ARM and should not impact other builds, and it is already removed in the Node20 patch as well

@robertsLando robertsLando merged commit 78459a6 into main Jan 30, 2025
4 checks passed
@robertsLando robertsLando deleted the fix-patch18.20.6 branch January 30, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faulpeltz faulpeltz faulpeltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node 18 WIN arm64 build is failing
2 participants
@robertsLando @faulpeltz