fix: remove is-core-module dependency
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node.js from v6.13.0, v8.10.0, v9.3.0 includes `module.builtinModules` which we can use to natively check if some module belongs to Node.js core or not. This drops not one, but _three_ dependencies from `pkg`: https://npmgraph.js.org/?q=is-core-module, removing 70 KB of bloat.
robertsLando
changed the title
is-core-module dependencyis-core-module dependency
Vylpes
pushed a commit
to Vylpes/random-bunny
that referenced
this pull request
Sep 10, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@yao-pkg/pkg](https://github.com/yao-pkg/pkg) | devDependencies | minor | [`5.12.0` -> `5.13.0`](https://renovatebot.com/diffs/npm/@yao-pkg%2fpkg/5.12.0/5.13.0) | --- ### Release Notes <details> <summary>yao-pkg/pkg (@​yao-pkg/pkg)</summary> ### [`v5.13.0`](https://github.com/yao-pkg/pkg/blob/HEAD/CHANGELOG.md#5130-2024-09-06) [Compare Source](yao-pkg/pkg@v5.12.1...v5.13.0) ##### Features - bump [email protected] with node 20.17.0 and 18.20.4 support ([dda9032](yao-pkg/pkg@dda9032)) ##### Bug Fixes - wrong placeholder replaced in windows binary ([#​86](yao-pkg/pkg#86)) ([d9b28c3](yao-pkg/pkg@d9b28c3)) ### [`v5.12.1`](https://github.com/yao-pkg/pkg/blob/HEAD/CHANGELOG.md#5121-2024-08-14) [Compare Source](yao-pkg/pkg@v5.12.0...v5.12.1) ##### Bug Fixes - remove `is-core-module` dependency ([#​77](yao-pkg/pkg#77)) ([2f27414](yao-pkg/pkg@2f27414)) - run prebuild-install only if actually used by the package ([#​83](yao-pkg/pkg#83)) ([2a046e4](yao-pkg/pkg@2a046e4)) ##### Chores - drop package-lock file uploaded by error ([ba407ef](yao-pkg/pkg@ba407ef)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.vylpes.xyz/RabbitLabs/random-bunny/pulls/216 Reviewed-by: Vylpes <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up after answer in #76.
Node.js from v6.13.0, v8.10.0, v9.3.0 includes
module.builtinModuleswhich we can use to natively check if some module belongs to Node.js core or not.This drops not one, but three dependencies from
pkg, removing 70 KB of bloat: https://npmgraph.js.org/?q=is-core-module