fix: wrong placeholder replaced in windows binary #86
Conversation
|
@faulpeltz Thanks a lot for this! |
Head branch was pushed to by a user without write access
|
It seems my change broke node 16/18 somehow 😠 |
|
@faulpeltz could you also open a PR on pkg-fetch with the required fixes to the patch for nodejs 20.17? |
|
Do you plan merging this soon? It's a game changer :) Thanks for your work to you both. |
|
@blackholegalaxy Even if I merge this we still need to wait for yao-pkg/pkg-fetch#40 to land. Otherwise no macos support :( ATM I have been able to make everything work except macos arm 64 |
|
Just dropping by to say this is amazing work |
we could still rebuild binaries when executing pkg locally I guess in the meantime |
|
Let's see how this goes: https://github.com/yao-pkg/pkg-fetch/actions/runs/10722955285 If still not working I could temporary disable Mac arm64 build and make a new release with what is working right now giving that pkg is lot node versions behind latest |
|
Just a quick update here. I finally managed to make all build working and new release is coming with latest nodejs 18 and 20.17.0 support 🎉 Just need to wait for this to finish now Please consider sending some support here: https://github.com/sponsors/robertsLando 🙏🏼 ❤️ |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@yao-pkg/pkg](https://github.com/yao-pkg/pkg) | devDependencies | minor | [`5.12.0` -> `5.13.0`](https://renovatebot.com/diffs/npm/@yao-pkg%2fpkg/5.12.0/5.13.0) | --- ### Release Notes <details> <summary>yao-pkg/pkg (@​yao-pkg/pkg)</summary> ### [`v5.13.0`](https://github.com/yao-pkg/pkg/blob/HEAD/CHANGELOG.md#5130-2024-09-06) [Compare Source](yao-pkg/pkg@v5.12.1...v5.13.0) ##### Features - bump [email protected] with node 20.17.0 and 18.20.4 support ([dda9032](yao-pkg/pkg@dda9032)) ##### Bug Fixes - wrong placeholder replaced in windows binary ([#​86](yao-pkg/pkg#86)) ([d9b28c3](yao-pkg/pkg@d9b28c3)) ### [`v5.12.1`](https://github.com/yao-pkg/pkg/blob/HEAD/CHANGELOG.md#5121-2024-08-14) [Compare Source](yao-pkg/pkg@v5.12.0...v5.12.1) ##### Bug Fixes - remove `is-core-module` dependency ([#​77](yao-pkg/pkg#77)) ([2f27414](yao-pkg/pkg@2f27414)) - run prebuild-install only if actually used by the package ([#​83](yao-pkg/pkg#83)) ([2a046e4](yao-pkg/pkg@2a046e4)) ##### Chores - drop package-lock file uploaded by error ([ba407ef](yao-pkg/pkg@ba407ef)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.vylpes.xyz/RabbitLabs/random-bunny/pulls/216 Reviewed-by: Vylpes <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
When replacing PAYLOAD_POSITION and similar placeholders, the producer always replaces the first occurence of the placeholder, but on the current Windows binaries the placeholder which needs to be replaced is the correct one (the first one is source text)
This causes the Windows binary to crash on startup. Fixes #85