fix: add missing arch to nativePrebuildInstall cache #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise when packaging for multiple architectures, pkg might end up picking up a cached binary for a different arch.
robertsLando
changed the title
robertsLando
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise when packaging for multiple architectures, pkg might end up picking up a cached binary for a different arch.
In general that code is a bit finicky and it will only really work for packages that actually use
prebuild-install, and currently also fails for any prebuild napi package, as you need to pass-r/--runtime napitoprebuild-installfor that to work, which is a different bug.I'm currently just doing my own workarounds for native packages that this doesn't handle (e.g.
pnpm rebuild, orpnpm install --force, before invokingpkgper target, rather than for all targets at once. It would have been much nicer if there was a more general way to handle this or to give per package hooks topkgto handle packages with special requirements.Contributed on behalf of Swimm