Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNUstep / Android compatibility changes #529

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

triplef
Copy link

@triplef triplef commented Aug 3, 2020

A couple small changes needed to build YapDatabase with the GNUstep Android toolchain:

  • added __bridge annotations in various places (mainly to convert from/to void pointers) – these seem to be optional in these places with Apple’s toolchains (not sure why), but also make the code more explicit.
  • added support for building without OS_OBJECT_USE_OBJC, i.e. when libdispatch objects are not bridged to ObjC objects.
  • Use isCancelled getter for NSProgress’ cancelled property – both getters are supported on Apple platforms, but GNUstep only defines this one getter.

As most of these are fairly small changes I thought you might be willing to upstream these, but if not we’re also happy to keep using our branch.

We’ve been running YapDatabase with these changes on Android for a couple of months now for our app (currently in beta), and it’s been working great.

rupertdaniel and others added 3 commits August 3, 2020 10:29
This is needed when building for non-Apple platforms, e.g. for Android using GNUstep/libdispatch.
Required when building using GNUstep.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants