Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: set default nmMode to hardlinks-local #4504

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

jdanil
Copy link
Contributor

@jdanil jdanil commented May 29, 2022

What's the problem this PR addresses?

Addresses one of the checklist items listed for Yarn 4 in #3591.

How did you fix it?

Updated the default value for nmMode.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

Sorry, something went wrong.

@jdanil jdanil force-pushed the feat/nm-mode-hardlinks-local branch from 7fc967b to 86b3c67 Compare May 29, 2022 06:49
@jdanil jdanil marked this pull request as ready for review May 29, 2022 08:16
@merceyz merceyz added the major label May 30, 2022
@merceyz merceyz changed the title feat: set default nmMode to hardlinks-local feat!: set default nmMode to hardlinks-local May 30, 2022
@arcanis arcanis requested a review from larixer June 1, 2022 09:11
@arcanis
Copy link
Member

arcanis commented Jun 1, 2022

Good for you @larixer ?

@merceyz merceyz mentioned this pull request Jun 1, 2022
13 tasks
larixer
larixer previously approved these changes Jun 1, 2022
Copy link
Member

@larixer larixer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arcanis @jdanil I'm not sure why E2E NM Babel fails, it works for me locally on OS X. The PR looks good! Approved.

@jdanil
Copy link
Contributor Author

jdanil commented Jun 1, 2022

I'm not sure why E2E NM Babel fails

Not familiar with the CI jobs, but I thought they might be a bit flaky? It looks like they've been failing on some other PRs too. I couldn't tell much about the failures from the logs.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@merceyz
Copy link
Member

merceyz commented Jun 1, 2022

The Babel repo has plugins that don't work with Yarn v4

@arcanis arcanis merged commit 1a489d1 into yarnpkg:master Jun 2, 2022
@jdanil jdanil deleted the feat/nm-mode-hardlinks-local branch June 2, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants