feat(foreach)!: automatically enable --verbose
in tty environments
#4595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
One of the 4.x items in #3591: automatically enabling the
-v,--verbose
flag ofyarn workspaces foreach
inside TTY environments.The reasoning behind this is the fact that it's a lot more useful to see what output comes from which workspace, and it's consistent with what we do in
@yarnpkg/shell
with background jobs (only enabling verbose output and prefixes in TTYs).How did you fix it?
Added an
isTTY
check.I've also tried to add tests for it, but I can't trick
child_process
/cross-spawn
/execUtils
into making the process think it's running inside a TTY.Because of this, the only alternative I see is using
node-pty
and processing the output, which is something I wouldn't wish on my worst enemy, so no tests for now.Checklist