-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writes a PnP spec #4671
Merged
Merged
Writes a PnP spec #4671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
added a commit
that referenced
this pull request
Aug 8, 2022
* Writes a PnP spec * Formalizes the algorithms * Updates the PnP header * Addresses feedbacks from evanw/esbuild#1985 * Starts writing reusable tests * More tests, clarifications on FIND_PNP_MANIFEST * Updates style for code segments * Adds tests for aliases * Fixes inadvertent default setting change * Fixes tests * Versions
merceyz
pushed a commit
that referenced
this pull request
Sep 21, 2022
* Writes a PnP spec * Formalizes the algorithms * Updates the PnP header * Addresses feedbacks from evanw/esbuild#1985 * Starts writing reusable tests * More tests, clarifications on FIND_PNP_MANIFEST * Updates style for code segments * Adds tests for aliases * Fixes inadvertent default setting change * Fixes tests * Versions
merceyz
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Writes a PnP spec * Formalizes the algorithms * Updates the PnP header * Addresses feedbacks from evanw/esbuild#1985 * Starts writing reusable tests * More tests, clarifications on FIND_PNP_MANIFEST * Updates style for code segments * Adds tests for aliases * Fixes inadvertent default setting change * Fixes tests * Versions
13 tasks
merceyz
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Writes a PnP spec * Formalizes the algorithms * Updates the PnP header * Addresses feedbacks from evanw/esbuild#1985 * Starts writing reusable tests * More tests, clarifications on FIND_PNP_MANIFEST * Updates style for code segments * Adds tests for aliases * Fixes inadvertent default setting change * Fixes tests * Versions
merceyz
pushed a commit
that referenced
this pull request
Dec 20, 2022
* Writes a PnP spec * Formalizes the algorithms * Updates the PnP header * Addresses feedbacks from evanw/esbuild#1985 * Starts writing reusable tests * More tests, clarifications on FIND_PNP_MANIFEST * Updates style for code segments * Adds tests for aliases * Fixes inadvertent default setting change * Fixes tests * Versions
merceyz
pushed a commit
that referenced
this pull request
Feb 1, 2023
* Writes a PnP spec * Formalizes the algorithms * Updates the PnP header * Addresses feedbacks from evanw/esbuild#1985 * Starts writing reusable tests * More tests, clarifications on FIND_PNP_MANIFEST * Updates style for code segments * Adds tests for aliases * Fixes inadvertent default setting change * Fixes tests * Versions
merceyz
pushed a commit
that referenced
this pull request
Mar 16, 2023
* Writes a PnP spec * Formalizes the algorithms * Updates the PnP header * Addresses feedbacks from evanw/esbuild#1985 * Starts writing reusable tests * More tests, clarifications on FIND_PNP_MANIFEST * Updates style for code segments * Adds tests for aliases * Fixes inadvertent default setting change * Fixes tests * Versions
merceyz
pushed a commit
that referenced
this pull request
May 1, 2023
* Writes a PnP spec * Formalizes the algorithms * Updates the PnP header * Addresses feedbacks from evanw/esbuild#1985 * Starts writing reusable tests * More tests, clarifications on FIND_PNP_MANIFEST * Updates style for code segments * Adds tests for aliases * Fixes inadvertent default setting change * Fixes tests * Versions
merceyz
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Writes a PnP spec * Formalizes the algorithms * Updates the PnP header * Addresses feedbacks from evanw/esbuild#1985 * Starts writing reusable tests * More tests, clarifications on FIND_PNP_MANIFEST * Updates style for code segments * Adds tests for aliases * Fixes inadvertent default setting change * Fixes tests * Versions
merceyz
pushed a commit
that referenced
this pull request
Nov 14, 2023
* Writes a PnP spec * Formalizes the algorithms * Updates the PnP header * Addresses feedbacks from evanw/esbuild#1985 * Starts writing reusable tests * More tests, clarifications on FIND_PNP_MANIFEST * Updates style for code segments * Adds tests for aliases * Fixes inadvertent default setting change * Fixes tests * Versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Now that it seems fairly stable, we'd like to standardize the JSON format used by the PnP resolver. This way third-party projects can safely rely on it and build their own integrations.
Ref: evanw/esbuild#1985
How did you fix it?
Start implementing a documentation about the PnP JSON format. First draft.
Url: https://deploy-preview-4671--yarn2.netlify.app/advanced/pnp-spec
Checklist